Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless cone twist joint #16285

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

yiwenxue
Copy link
Contributor

Re: #https://github.com/cocos/3d-tasks/issues/17708

Changelog

  • rm cone twist joint directly, since it's not implemented and not planned

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@yiwenxue
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -49557,28 +49557,20 @@
              */
             HINGE = 1,
             /**
              * @en
-             * Cone twist constraint.
-             * @zh
-             * 锥形扭转约束。
-             * @deprecated coneTwist is deprecated, please use configurable instead
-             */
-            CONE_TWIST = 2,
-            /**
-             * @en
              * Fixed constraint.
              * @zh
              * 固定约束。
              */
-            FIXED = 3,
+            FIXED = 2,
             /**
              * @en
              * Configurable constraint.
              * @zh
              * 可配置约束。
              */
-            CONFIGURABLE = 4
+            CONFIGURABLE = 3
         }
         /**
          * @en
          * Constraint Mode for degrees of freedom.
@@ -66542,12 +66534,8 @@
         export interface _cocos_physics_spec_i_character_controller__ICapsuleCharacterController extends _cocos_physics_spec_i_character_controller__IBaseCharacterController {
             setRadius(value: number): void;
             setHeight(value: number): void;
         }
-        /**
-         * @deprecated ConeTwistConstraint is deprecated, please use ConfigurableConstraint instead
-         */
-        export type _cocos_physics_spec_i_physics_constraint__IConeTwistConstraint = _cocos_physics_spec_i_physics_constraint__IBaseConstraint;
         export interface _cocos_physics_framework_physics_selector__IPhysicsWrapperObject {
             PhysicsWorld?: _types_globals__Constructor<_cocos_physics_spec_i_physics_world__IPhysicsWorld>;
             RigidBody?: _types_globals__Constructor<_cocos_physics_spec_i_rigid_body__IRigidBody>;
             BoxCharacterController?: _types_globals__Constructor<_cocos_physics_spec_i_character_controller__IBoxCharacterController>;
@@ -66562,12 +66550,8 @@
             SimplexShape?: _types_globals__Constructor<_cocos_physics_spec_i_physics_shape__ISimplexShape>;
             PlaneShape?: _types_globals__Constructor<_cocos_physics_spec_i_physics_shape__IPlaneShape>;
             PointToPointConstraint?: _types_globals__Constructor<_cocos_physics_spec_i_physics_constraint__IPointToPointConstraint>;
             HingeConstraint?: _types_globals__Constructor<_cocos_physics_spec_i_physics_constraint__IHingeConstraint>;
-            /**
-             * @deprecated cone twist constraint is deprecated, please use configurable instead
-             */
-            ConeTwistConstraint?: _types_globals__Constructor<_cocos_physics_spec_i_physics_constraint__IConeTwistConstraint>;
             FixedConstraint?: _types_globals__Constructor<_cocos_physics_spec_i_physics_constraint__IFixedConstraint>;
             ConfigurableConstraint?: _types_globals__Constructor<_cocos_physics_spec_i_physics_constraint__IConfigurableConstraint>;
         }
         export interface _cocos_physics_framework_physics_selector__IPhysicsBackend {

@yiwenxue yiwenxue requested a review from lealzhan September 19, 2023 11:01
@lealzhan lealzhan merged commit 0a5befb into cocos:v3.8.1 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants